Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with @syntax #1581

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Fix issues with @syntax #1581

merged 2 commits into from
Dec 15, 2016

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Dec 15, 2016

Fixes #1109. Expand user when using @~/path syntax
Fixes #1577. Allows use of '@' as a value (for DNS commands for example)

@derekbekoe
Copy link
Member

Should get @johanste to take a look also as I think sometimes the shell will expand ~.

@tjprescott tjprescott changed the title Expand user when using @~/path syntax Fix issues with @syntax Dec 15, 2016
@tjprescott
Copy link
Member Author

@derekbekoe from the Python documentation:

On Unix and Windows, return the argument with an initial component of ~ or ~user replaced by that user‘s home directory.
...
If the expansion fails or if the path does not begin with a tilde, the path is returned unchanged.

So if the shell does the expansion first, then there's no ~ in the path when this code get there and it is unchanged.

@tjprescott tjprescott merged commit 575de6b into Azure:master Dec 15, 2016
@tjprescott tjprescott deleted the ExpandUserFix branch December 15, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants